[Concurrency] Disallow Sendable annotation on methods of non-Sendable types #69177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angela-laar
requested review from
ktoso,
kavon,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
hborla
reviewed
Oct 13, 2023
lib/Sema/TypeCheckAttr.cpp
Outdated
| // Prevent Sendable Attr from being added to methods of non-sendable types | ||
| if (auto *funcDecl = dyn_cast<AbstractFunctionDecl>(D)) { | ||
| if (auto baseType = funcDecl->getImplicitSelfDecl()->getTypeInContext()) { | ||
| if (!isSendableType(dc->getParentModule(), baseType)) { |
There was a problem hiding this comment.
How does this behave for conditional conformances? e.g.
struct S<T> {
let t: T
@Sendable func test() {}
}
extension S: Sendable where T: Sendable {
@Sendable func test2() {}
}It seems like the first @Sendable should be diagnosed but the second should not.
There was a problem hiding this comment.
It should work out. isSendableType() calls TypeChecker::conformsToProtocol() which checks conditional requirements, and getSelfTypeInContext() maps the interface type of self into the function's own generic environment, so the generic parameters become archetypes that satisfy those conditional requirements. Worth adding a test though!
slavapestov
reviewed
Oct 15, 2023
angela-laar
force-pushed
the
prevent-sendable-attribute
branch
5 times, most recently
from
bfeed03 to
11aaebc
Compare
|
@swift-ci please smoke test |
hborla
approved these changes
Oct 16, 2023
angela-laar
force-pushed
the
prevent-sendable-attribute
branch
from
0efd4df to
558b5dd
Compare
angela-laar
force-pushed
the
prevent-sendable-attribute
branch
from
558b5dd to
e779b05
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow Sendable annotation on methods of non-Sendable types.