Skip to content

[CMake] [Darwin] Don't add the Darwin overlay as a dependency if the overlays aren't being built #69221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

ian-twilightcoder
Copy link
Contributor

Allow for the overlays to not be built in Darwin by respecting SWIFT_BUILD_SDK_OVERLAY.

Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…overlays aren't being built

Allow for the overlays to not be built in Darwin by respecting SWIFT_BUILD_SDK_OVERLAY.
@ian-twilightcoder
Copy link
Contributor Author

@swift-ci smoke test

@ian-twilightcoder
Copy link
Contributor Author

@swift-ci test

@ian-twilightcoder ian-twilightcoder merged commit e364b23 into swiftlang:main Oct 18, 2023
@ian-twilightcoder ian-twilightcoder deleted the overlay-dependents branch October 18, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants