[embedded] Allow metadata for DynamicSelfType to support using Self in classes #69266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for some guidance on this :) The immediate problem I observed is that in a class method, using Self ends up emitting a thick metadata instruction for the dynamic self type and that fails the current assert we have for embedded Swift. This particular case seems to be fixable by just allowing metadata emission on DynamicSelfType in IRGen, but I'm wondering if there's any other considerations for dynamic self we need to take into look into :)
Fixes rdar://117174867