Skip to content

[CSBindings] Delay inference through OptionalObject if "object" is l-… #69292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Oct 19, 2023

…value capable

Inference cannot be allowed in cases where both sides are type
variables and optional type is l-value capable because it results
in binding "optional" to an optional type and later discovering
a contextual type that is l-value optional i.e. if "optional type"
is resolved by selecting subscript overload.

@xedin xedin requested a review from hborla as a code owner October 19, 2023 23:17
@xedin
Copy link
Contributor Author

xedin commented Oct 19, 2023

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Oct 20, 2023

@swift-ci please test source compatibility

…value capable

Inference cannot be allowed in cases where both sides are type
variables and optional type is l-value capable because it results
in binding "optional" to an optional type and later discovering
a contextual type that is l-value optional i.e. if "optional type"
is resolved by selecting subscript overload.
@xedin xedin force-pushed the delay-inference-from-OptionalObject branch from 32f6e5d to 700a57a Compare October 20, 2023 04:34
@xedin
Copy link
Contributor Author

xedin commented Oct 20, 2023

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Oct 20, 2023

@swift-ci please test source compatibility

@xedin
Copy link
Contributor Author

xedin commented Oct 20, 2023

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Nov 1, 2023

@swift-ci please smoke test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Nov 1, 2023

I'm going to land this and XFAIL CareKit until Xcode issue is resolved.

@xedin
Copy link
Contributor Author

xedin commented Nov 3, 2023

@swift-ci please build toolchain maOS platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant