[ConstraintSystem] Bring back one-way pattern solving for for-in stat… #69304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ements (outside closures) Type-checker separates `where` clause from `for-in` statement's pattern/sequence in closure contexts which works as a natural barrier for inference, but for-in statements in i.e. function bodies still type-check all of the for-in statement components together, so we need to make sure that where clause cannot be used to infer a type of the pattern before its sequence expression. Resolves: rdar://117220710
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
hborla
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ements (outside closures)
Type-checker separates
whereclause fromfor-instatement's pattern/sequence in closure contextswhich works as a natural barrier for inference, but for-in statements in i.e. function bodies still type-check
all of the for-in statement components together, so we need to make sure that where clause cannot be
used to infer a type of the pattern before its sequence expression.
Resolves: rdar://117220710