[wasm][test] Remove unused argc/argv parameters from @main decl #69347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In WebAssembly, `main` function is mangled differently depending on if it takes argc/argv or not. If it doesn't take them, it's mangled to `main` as well as other platforms, so remove unused argc/argv in executable tests to avoid linkage failure.
|
@swift-ci Please smoke test |
kateinoigakukun
added
test suite
kateinoigakukun
deleted the
pr-1b946c6c06d5895a3717889966e40733ad6350e9
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WebAssembly,
mainfunction is mangled differently depending on if it takes argc/argv or not. If it doesn't take them, it's mangled tomainas well as other platforms, so remove unused argc/argv in executable tests to avoid linkage failure.This is a preparation to enable executable tests against WebAssembly.
Resolves part of rdar://116488131