SILGen fixes for -experimental-skip-non-exportable-decls #69392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts swiftlang#69214. Resolves rdar://117020997
Resolves rdar://117438934
Functions that are nested within other functions are not exportable to clients since they cannot be called directly by clients. However, they need still to be emitted during SILGen when -experimental-skip-non-exportable-decls is specified so walk the decl context hierarchy when determining whether to skip emitting a function. Resolves rdar://117440503
tshortli
force-pushed
the
skip-non-exportable-decls-fixes
branch
from
a01ed12 to
114a46a
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes for SILGen behavior when -experimental-skip-non-exportable-decls is specified. See commits for details.
Resolves rdar://117020997&117438934&117440503