Remove tailing semi-colons in .swift #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,5 @@ | |||
| // RUN: %target-parse-verify-swift -parse-as-library | |||
|
|
|||
| // make sure trailing semicolons are valid syntax in toplevel library code. | |||
| var x = 4; | |||
| var x = 4 | |||
|
Well, if we remove all of these semicolons (which I agree is the right thing for individual tests), we decrease our test coverage for semicolons. Would you mind writing some targeted tests for the parser? |
dduan
force-pushed
the
semicolon_removal
branch
from
1837416 to
239c662
Compare
|
@gribozavr I'll take a stab at it. |
|
@gribozavr test added, what you think? |
|
@dduan Thanks! |
gribozavr
added a commit
that referenced
this pull request
Dec 21, 2015
Remove tailing semi-colons in .swift
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
[Hotfix] Return results accordingly from the spawned process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sed Force Awakens (sorry, did this while waiting for the movie to start).
build-script -RTall passes on OS X.