Emit default arg for a package func during silgen #69414
Conversation
|
|
||
| // RUN: %target-build-swift -I %t -L %t -lUtils %s -o %t/main %target-rpath(%t) -package-name mypkg | ||
|
|
||
| // RUN: %target-run %t/main %t/%target-library-name(Utils) > %t/run-result.output |
There was a problem hiding this comment.
Seems like this test may need a REQUIRES: executable_test. I would also organize it under test/Interpreter rather than test/Sema.
There was a problem hiding this comment.
does the test really need to be executable? I think test/TBD/ is the best place for it and it should not be executable, just check that the symbol appears in the TBD.
There was a problem hiding this comment.
You don't even need to write any CHECK: lines in a TBD test for this, the -validate-tbd-against-ir infrastructure does all the validation automatically by matching up the tbd contents and LLVM IR.
There was a problem hiding this comment.
you're right we don't need an executable; removed, added the flag, and moved to test/tbd.
elsh
changed the title
in TBD, causing a linker error. This is because the default arg is not generated during silgen. This PR adds a check to make sure it's represented by SILDeclRef and its linkage emitted. Resolves rdar://116184295
|
@swift-ci smoke test |
|
@swift-ci smoke test |
If a package func has a default arg, its symbol is not generated
in TBD, causing a linker error. This is because the default arg
is not generated during silgen. This PR adds a check to make sure
it's represented by SILDeclRef and its linkage emitted.
Resolves rdar://116184295