Preliminary SILGen support for address-only typed throws #69430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
DougGregor
reviewed
Oct 26, 2023
| AbstractionPattern::getErrorConvention(TypeConverter &TC) const { | ||
| // Tuples should be destructured. | ||
| if (isTuple()) { | ||
| return Destructured; |
There was a problem hiding this comment.
We ban tuple types from being thrown up in the type checker now, and even if we allowed them there... I think we'd still pass them indirectly here, right?
There was a problem hiding this comment.
Good catch, I’ll remove this. It was just a copy and paste
| @@ -713,6 +713,15 @@ bool SILModuleConventions::isPassedIndirectlyInSIL(SILType type, SILModule &M) { | |||
| return false; | |||
| } | |||
|
|
|||
| bool SILModuleConventions::isThrownIndirectlyInSIL(SILType type, SILModule &M) { | |||
| if (SILModuleConventions(M).loweredAddresses) { | |||
There was a problem hiding this comment.
Suggested change
| if (SILModuleConventions(M).loweredAddresses) { | |
| if (SILModuleConventions(M).useLoweredAddresses()) { |
slavapestov
force-pushed
the
silgen-typed-throws-wip
branch
from
52d69a9 to
581776b
Compare
|
@swift-ci Please smoke test |
This was referenced Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the thrown error type is address-only, our function type has an indirect error result. Handle this in type lowering and SILGen prolog/epilog emission.
Next steps are introducing a zero-operand
throw_addrinstruction to exit out of a block after initializing the thrown error result, and setting up a stack-allocated box to receive the indirect error result from a try_apply, all the conversions and re-abstraction support, etc.