Fix the fixit for specialized non-generic types #6944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a non-generic type is specialized a fixit is provided to remove the generic arguments. The DiagnosticEngine turns a SourceRange into a CharSourceRange by re-lexing the token at `SourceRange::End`. The problem solved by this change occurs, if the non-generic type is nested in an other generic type like this: let a: GenericType<NongenericType<NongenericType>> The lexer doesn't know that the closing angle brackets are individual tokens leading to the removal of both of them. We can work around this by directly specifying the start and end locations.
|
@swift-ci please smoke test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a non-generic type is specialized, a fixit is provided to remove the
generic arguments. The DiagnosticEngine turns a SourceRange into a
CharSourceRange by re-lexing the token at
SourceRange::End.The problem solved by this change occurs, if the non-generic type is
nested in an other generic type like this:
The lexer doesn't know that the closing angle brackets are individual
tokens leading to the removal of both of them. We can work around this
by directly specifying the start and end locations.