[cxx-interop] Lower macOS deployment target version for the Cxx module #69512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
@egorzhdan what about the CxxStdlib module? |
The CMake flag `DEPLOYMENT_VERSION_OSX` is currently only passed to the C compiler. This change makes sure it is also passed to the Swift compiler, e.g. when building Swift-only targets like Cxx or CxxStdlib. rdar://117699474
The Cxx module does not rely on any modern OS features. It can be deployed to older macOS versions. rdar://117699474
egorzhdan
force-pushed
the
egorzhdan/cxx-lower-deployment-target
branch
from
e12339f to
00cdb66
Compare
Right, we should apply the same CMake flag to CxxStdlib as well |
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
@swift-ci please test Windows |
hyp
approved these changes
Oct 31, 2023
|
@egorzhdan please pick this to 5.10 as well. |
etcwilde
approved these changes
Nov 1, 2023
| @@ -236,6 +237,10 @@ function(_add_target_variant_swift_compile_flags | |||
|
|
|||
| if("${sdk}" IN_LIST SWIFT_DARWIN_PLATFORMS) | |||
| set(sdk_deployment_version "${SWIFT_SDK_${sdk}_DEPLOYMENT_VERSION}") | |||
| if("${sdk}" STREQUAL "OSX" AND DEFINED VARIANT_DEPLOYMENT_VERSION_OSX) | |||
There was a problem hiding this comment.
Will we need this configuration for each Darwin platform, or only macOS?
There was a problem hiding this comment.
We might potentially need this on other Darwin platforms in the future, but for now we only expect to use this for macOS. I can add the corresponding CMake logic for iOS, etc. if you think it's worth having it in tree.
egorzhdan
added a commit
that referenced
this pull request
Nov 6, 2023
…rces See #69512 rdar://117699474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cxx module does not rely on any modern OS features. It can be deployed to older macOS versions.
rdar://117699474