Skip to content

A couple of bridging cleanups #69534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Conversation

hamishknight
Copy link
Contributor

Follow-up to #69440. Rename get() to unbridged(), improve some bridging interfaces, and remove unbridged + bridged free functions.

Define using the wrapper macro.
Migrate a bunch of structs to classes, and
uppercase field names.
We can now use the constructors on the bridged
wrappers, and `unbridged` methods.
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@xedin xedin removed their request for review October 31, 2023 21:58
Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Definitely open to some name other than unbridged, but IMO it's better than get.

@hamishknight hamishknight merged commit e19954f into swiftlang:main Oct 31, 2023
@hamishknight hamishknight deleted the bridgnt branch October 31, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants