Serialization: Fix deserializing opaque types details for computed properties and subscripts #69546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
commented
Oct 31, 2023
|
@swift-ci Please smoke test |
xymus
changed the title
tshortli
reviewed
Oct 31, 2023
xymus
force-pushed
the
deserialization-opaque-var
branch
2 times, most recently
from
1329055 to
7cb9e5a
Compare
tshortli
reviewed
Nov 1, 2023
tshortli
approved these changes
Nov 1, 2023
xymus
force-pushed
the
deserialization-opaque-var
branch
3 times, most recently
from
e727b65 to
cda347e
Compare
|
@swift-ci Please smoke test |
|
I significantly changed this PR to move the core logic from the reader side to the writer side. The accessors were not always available at deserialization, which lead to unexpected results. Now we determine if the underlying type should be exported at serialization, write it as a bit in the swiftmodule, and use it to decide if we should read the underlying information at deserialization. |
tshortli
approved these changes
Nov 1, 2023
…s and subscripts A client shouldn't know about the underlying type of an opaque type unless it can see the body of the naming decl. Attempting to read it can lead to accessing a hidden dependency and a compiler crash. This was protected by a check specific to function decls but var decls and subscripts were not handled. To support them we have to move this logic to the writer side where we have access to the full AbstractStorageDecl and write in the swifmodule whether the underlying type should be visible outside of the module. rdar://117607906
xymus
force-pushed
the
deserialization-opaque-var
branch
from
cda347e to
f2d1627
Compare
|
Extracted the test to two new files where one is restricted to macOS hosts. @swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A client shouldn't know about the underlying type of an opaque type unless it can see the body of the naming decl. Attempting to read it can lead to accessing a hidden dependency and a compiler crash.
This was protected by a check specific to function decls but var decls and subscripts were not handled. To support them we have to move this logic to the writer side where we have access to the full AbstractStorageDecl and write in the swifmodule whether the underlying type should be visible outside of the module.
rdar://117607906