ModuleInterface: Resolve types of CustomAttrs when printing #69560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When printing the CustomAttrs attached to a decl, those attrs may not have been type checked yet if lazy typechecking is enabled. We need to make sure that printing invokes a request that will resolve the type. Resolves rdar://117443319
|
@swift-ci please smoke test |
slavapestov
reviewed
Nov 1, 2023
| auto attr = cast<CustomAttr>(this); | ||
| if (auto type = attr->getType()) { | ||
| if (auto type = | ||
| D->getResolvedCustomAttrType(const_cast<CustomAttr *>(attr))) { |
There was a problem hiding this comment.
Should getType() be made private?
There was a problem hiding this comment.
There are a lot of existing uses of getType() that don't need to go through something like getResolvedCustomAttrType() because they get called on a CustomAttr that was retrieved via a request that resolves the type. It's only when printing or serializing that we work with CustomAttrs abstractly (without knowing that we want a result builder, property wrapper, etc.) and therefore need this.
tshortli
deleted the
module-interface-lazy-typecheck-qualified-global-actors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When printing the CustomAttrs attached to a decl, those attrs may not have been type checked yet if lazy typechecking is enabled. We need to make sure that printing invokes a request that will resolve the type.
Resolves rdar://117443319