Task Executors: Prepare for new TaskExecutor protocol #69568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
requested review from
kavon,
hborla,
slavapestov,
xedin and
tshortli
as code owners
ktoso
force-pushed
the
wip-prepare-task-executor-protocol
branch
from
b13c21c to
9e75142
Compare
ktoso
added
the
concurrency
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
rjmccall
requested changes
Nov 1, 2023
include/swift/ABI/Executor.h
Outdated
|
|
||
| /// Deprecated name for "SerialExecutorRef"; When it was first introduced it was ExecutorRef, | ||
| /// but it always meant specifically a serial executor. | ||
| typedef SerialExecutorRef ExecutorRef; |
There was a problem hiding this comment.
Do we need this? Is there code using this header outside our repository?
There was a problem hiding this comment.
Probably not, let me remove this.
@rokhinip I don't think you're using the actual header from Swift anywhere right? If anything it would have been a copy I expect.
include/swift/AST/Builtins.def
Outdated
| /// reference. | ||
| BUILTIN_MISC_OPERATION_WITH_SILGEN(BuildOrdinaryTaskExecutorRef, | ||
| "buildOrdinaryTaskExecutorRef", "n", Special) | ||
|
|
There was a problem hiding this comment.
I don't know that you need to copy this stuff about builtins. Let's wait until we have a need to build task executors into the compiler.
There was a problem hiding this comment.
Okey yeah we can add when necessary, thanks!
|
@swift-ci please smoke test and merge |
|
Addressed comments, this is just the rename and adding the new type then |
ktoso
changed the title
ktoso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares for the addition of a TaskExecutor protocol that will enable us to "run on the thread of the task executor, however be isolated to the actor".
Next we'll start tracking BOTH in executor tracking and adjust enqueue / actor drain code to respect these as well.
The APIs to set one of these are outlined in swiftlang/swift-evolution#2187 which details the withExecutor and Task(on: TaskExecutor) performance tuning APIs. They allow to "not switch off the task's preferred executor".