build: early exit on error #69582
Merged
build: early exit on error #69582
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
bnbarham
approved these changes
Nov 1, 2023
|
https://ci-external.swift.org/job/swift-PR-windows/18257/console ... nope, its still silently failing. |
|
@swift-ci please test |
|
Gah, its still not reporting the error properly. |
tristanlabelle
approved these changes
Nov 2, 2023
|
@swift-ci please test Windows platform |
compnerd
force-pushed
the
early-exit
branch
2 times, most recently
from
b6b8435 to
126ee47
Compare
|
@swift-ci please test Windows platform |
Apply more error checking to ensure that failures do not slip through the various layers of invocation.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If build.ps1 fails, immediately exit rather than cleaning up. We may lose the error code in such situations.