[dispatch] Fix + and - operations on DispatchTime and DispatchWallTime #6961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... for the cases where `seconds` parameter is NaN or infinite. Fixes <rdar://problem/29764171>
|
@swift-ci Please test |
moiseev
added a commit
to moiseev/swift
that referenced
this pull request
Jan 31, 2017
swiftlang#6961) ... for the cases where `seconds` parameter is NaN or infinite. Fixes <rdar://problem/29764171> CCC: <rdar://problem/30276292>
|
This is not the behavior I would expect for |
|
I believe this is the behavior in libdispatch. |
|
I would not be surprised if C libdispatch did this inadvertently due to C's lack of checking. It doesn't seem useful for Swift's interface to duplicate that. |
|
/cc @ktopley-apple and @mwwa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... for the cases where
secondsparameter is NaN or infinite.rdar://problem/29764171