[Concurrency] Isolated global lets are not safe to access across actors.
#69616
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
requested review from
ktoso,
kavon,
slavapestov and
xedin
as code owners
hborla
force-pushed
the
isolated-global-let
branch
from
2f2a8ba to
80d5303
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
hborla
force-pushed
the
isolated-global-let
branch
from
80d5303 to
04be278
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #69598 but I forgot global variables!
Global
letvariables are initialized upon first access, so they cannot be synchronously accessed across actors.