Skip to content

[Embedded] enable random APIs if a RandomNumberGenerator is provided #69645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

phausler
Copy link
Contributor

@phausler phausler commented Nov 3, 2023

but leave system random number generators unavailable.

Some embedded systems can potentially provide a cryptographically secure pseudo random number generator. So in those cases we can leave the APIs that take a RandomNumberGenerator available and just require either folks to pass one in, or add extensions for using their own "system default random number generator".

… but leave system random number generators unavailable
@phausler phausler requested a review from kubamracek November 3, 2023 19:13
@phausler phausler requested a review from a team as a code owner November 3, 2023 19:13
@phausler
Copy link
Contributor Author

phausler commented Nov 3, 2023

@swift-ci please test

Copy link
Contributor

@glessard glessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phausler phausler merged commit 7a2c21d into swiftlang:main Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants