[sil] Fix the no-asserts build by not calling a ifndef NDEBUG method. #69652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
@swift-ci test windows platform |
drodriguez
reviewed
Nov 6, 2023
| @@ -1392,7 +1392,11 @@ class BlockPartitionState { | |||
| void print(llvm::raw_ostream &os) const { | |||
| os << SEP_STR << "BlockPartitionState[reached=" << reached | |||
| << ", needsUpdate=" << needsUpdate << "]\nid: "; | |||
| #ifndef NDEBUG | |||
| basicBlock->printID(os); | |||
There was a problem hiding this comment.
There's a couple more succ->printID(os) and pred->printID(os) in lines 1412 and 1417. Don't those need to be protected for NDEBUG builds too?
drodriguez
added a commit
to drodriguez/swift
that referenced
this pull request
Nov 8, 2023
…(part 2) PR swiftlang#69652 protected one call of `printID` but left another two in the file. Create two small lambdas to print the ID with `printID` or just print `NOASSERTS` depending on `NDEBUG` being defined. Change all the callsites of `printID` to use that lambda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixing the build.