Skip to content

Make sure we record "Never" as the thrown error type for try!/try? #69653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2023
Merged

Make sure we record "Never" as the thrown error type for try!/try? #69653

merged 1 commit into from
Nov 4, 2023

Conversation

DougGregor
Copy link
Member

We should always have a type here.

@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor DougGregor mentioned this pull request Nov 3, 2023
Merged
@DougGregor
Copy link
Member Author

@swift-ci please smoke test Linux

@DougGregor
Copy link
Member Author

The Windows failure is handled by #69655

@DougGregor DougGregor merged commit 47a6d67 into swiftlang:main Nov 4, 2023
@DougGregor DougGregor deleted the try-question-bang-never branch November 4, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DougGregor