Clarify the error we emit when we see an unexpected null pointer #69684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test |
al45tair
approved these changes
Nov 8, 2023
mikeash
approved these changes
Nov 8, 2023
| " while trying to cast value of type '%s' (%p)" | ||
| " to '%s' (%p)%s\n"; | ||
| const char * const msg = "Non-Optional value of type '%s' (%p)" | ||
| " holds a null pointer?!" |
There was a problem hiding this comment.
Suggested change
| " holds a null pointer?!" | |
| " holds a null pointer, which is not allowed by the type system." |
Thinking it's good to spell it out even more, in case someone doesn't understand why it's bad to have null in a non-optional.
There was a problem hiding this comment.
Revised message further:
Found a null pointer in a value of type '%s'. Non-Optional values are not allowed to hold null pointers. (Detected while casting to '%s')
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informal discussion suggests that the original wording wasn't obvious to everyone. Hopefully, this is clearer.
Old message: "Found unexpected null pointer value while trying to cast value of type '%s' to '%s'"
It seems folks didn't connect "null pointer" to "non-Optional value that came from Obj-C" and tended to focus on the destination type.
New message: "Non-Optional value of type '%s' holds a null pointer?! (Detected while casting to '%s')"
This de-emphasizes the target type of the cast and more clearly explains the actual problem.