Skip to content

[follow-up][Distributed]Adjust overload detection for distributed funcs #69688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2023
Merged

[follow-up][Distributed]Adjust overload detection for distributed funcs #69688

merged 1 commit into from
Nov 8, 2023

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Nov 7, 2023 •
edited
Loading

Follow up after review in https://github.com/apple/swift/pull/69596/files#r1383692925

I wasn't really able to find and make a test case for which case this is fixing though...?

I do not believe this is correct; if one of them is distributed, and mismatch on async, we should fall through to check the names below, not determine that they are always conflicting. They might have different argument names entirely.

Seems to imply different argument labels; but when that is the case we don't end up checking in this method anyway it seems 🤔

rdar://117818281

@ktoso ktoso mentioned this pull request Nov 7, 2023
Merged
@ktoso
Copy link
Contributor Author

ktoso commented Nov 7, 2023

@swift-ci please smoke test

@ktoso ktoso added concurrency Feature: umbrella label for concurrency language features distributed Feature → concurrency: distributed actor labels Nov 7, 2023
@ktoso
Copy link
Contributor Author

ktoso commented Nov 7, 2023

@swift-ci please smoke test

@ktoso ktoso changed the title Adjust overload detection for distributed funcs [follow-up][Distributed]Adjust overload detection for distributed funcs Nov 7, 2023
xedin
xedin approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should cover any difference in DeclNames - different base names, labels, number of arguments etc.

@ktoso
Copy link
Contributor Author

ktoso commented Nov 8, 2023

@swift-ci please smoke test Windows

@ktoso ktoso enabled auto-merge November 8, 2023 01:50
@ktoso ktoso merged commit d147898 into swiftlang:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@DougGregor DougGregor DougGregor approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

Assignees
No one assigned
Labels
concurrency Feature: umbrella label for concurrency language features distributed Feature → concurrency: distributed actor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktoso @xedin @DougGregor