[ownership-verifier] SubObject Borrowing + Better output for FileCheck + More tests #6972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shipVerifierTestingEnabled and use it to disable SILInstruction::verifyOperandOwnership The method SILInstruction::verifyOperandOwnership() is used in SILBuilder to ensure that as instructions are created, if there are any use failures, the error is caught at the moment the instruction is created. This makes debugging such failures trivial. *NOTE* This does not cause dataflow verification to occur. The problem is that when PrintMessageInsteadOfAssert is enabled, this causes dataflow failures to have their error messages emitted twice, complicating FileCheck testing of the verifier. Thus, this commit disables SILInstruction::verifyOperandOwnership() when PrintMessageInsteadOfAssert is enabled. PrintMessageInsteadOfAssert is renamed to 'IsSILOwnershipVerifierTestingEnabled' in light of its expanded role. rdar://29791263
…s forwarded @owned aggregates. I am going to add some negative tests in a forthcoming commit. I just wrote these locally and wanted to get them into tree. rdar://29791263
Previously, we would require an end_borrow for guaranteed subobject borrows. This was not the end design and of course would have triggered asserts since end_borrow only supports ending borrows of the same type (by design). This commit finishes the design by: 1. Verifying that subobject borrows do not have an end_borrow. This is done by asserting that subobject borrows do not have lifetime ending uses. 2. Treating uses of a subobject borrow as normal liveness uses of the base borrowed object. This means that the verifier will assert if there are any uses of borrowed subobjects after the base's end_value. rdar://29791263
|
@swift-ci Please smoke test and merge |
|
Linux test failure isn't me. It is a frontend compiler crasher. Lets try this again... |
|
@swift-ci Please smoke test linux platform |
1 similar comment
|
@swift-ci Please smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 3 different commits:
f462d20. This commit renames PrintMessageInsteadOfAssert => IsSILOwnershipTestingEnabled and disables the partial ownership verification that occurs via SILInstruction::verifyOperandOwnership(). This is invoked by SILBuilder to catch invalid ownership early when an instruction is created, rather than later during full verification. This is bad from the perspective of FileCheck testing since use errors will come up twice. Since PrintMessageInsteadOfAssert has a bigger purpose now, it makes sense to rename it.
60449d5. This commit just adds 2 tests that shows that the verifier allows through multiple levels of consumed aggregates being constructed.
f857f2c. This commit implements and adds tests for subobject borrowing.
rdar://29791263