[ASTGen] Generalize findSyntaxNodeInSourceFile(wantOutermost:true)
#69724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
astgen-findnode-outermost
branch
2 times, most recently
from
63db1ac to
b7f881f
Compare
|
@swift-ci Please smoke test |
When 'wantOutermost' is true, traverse the parent as long as the position is the same as the target position.
rintaro
force-pushed
the
astgen-findnode-outermost
branch
from
b7f881f to
2e26370
Compare
|
@swift-ci Please smoke test |
rintaro
commented
Nov 8, 2023
| { | ||
| while | ||
| let parentSyntax = currentSyntax.parent, | ||
| parentSyntax.position == resultSyntax.position { |
There was a problem hiding this comment.
It is a restriction that the outer nodes must stay in the same position, and it's inconsistent with the innermost node discovery. But in our use cases, this should be enough.
There was a problem hiding this comment.
Maybe we should have two separate methods like
// For macro expansion node discovery:
findTokenInSourceFile(in: exporetedSourceFile, at: sourceLoc)?
.innermostNode(ofType: AttributeSyntax.self)
// For partial ASTGen:
findTokenInSourceFile(in: exporetedSourceFile, at: sourceLoc)?
.outermostNodeAtSamePosition(ofType: ExprSyntax.self)
|
included in #69761 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
wantOutermostis true, keep looking the parent nodes as long as the position is the same as the innermost matching node, and return the last matching node found.