Skip to content

Distributed: Enabled availability checking in Distributed test #69738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Nov 9, 2023

Various distributed actors test cases were testing behavior that ultimately depends on availability checking but then disabled availability checking on the command line when building. This will break with future planned changes to availability checking infrastructure.

@tshortli tshortli requested a review from ktoso as a code owner November 9, 2023 02:35
@tshortli
Copy link
Contributor Author

tshortli commented Nov 9, 2023

@swift-ci please smoke test

@tshortli tshortli enabled auto-merge November 9, 2023 02:35
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks for the catch, LGTM

Various distributed actors test cases were testing behavior that ultimately
depends on availability checking but then disabled availability checking on the
command line when building. This will break with future planned changes to
availability checking infrastructure.
@tshortli tshortli force-pushed the distributed-actor-custom-executor-test-enable-availability-checking branch from 7064e50 to 941ac3c Compare November 9, 2023 04:57
@tshortli
Copy link
Contributor Author

tshortli commented Nov 9, 2023

Looks like several tests needed to be updated, I missed some when I was first testing.

@tshortli
Copy link
Contributor Author

tshortli commented Nov 9, 2023

@swift-ci please smoke test

@tshortli tshortli disabled auto-merge November 9, 2023 04:58
@tshortli tshortli enabled auto-merge November 9, 2023 07:21
@tshortli tshortli merged commit 8d0b90b into swiftlang:main Nov 9, 2023
@tshortli tshortli deleted the distributed-actor-custom-executor-test-enable-availability-checking branch November 9, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants