Skip to content

Update build.ps1 for installer changes for VCRuntime dlls #69743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Update build.ps1 for installer changes for VCRuntime dlls #69743

merged 1 commit into from
Nov 30, 2023

Conversation

tristanlabelle
Copy link
Contributor

Build script counterpart to swiftlang/swift-installer-scripts#256

@compnerd
Copy link
Member

compnerd commented Nov 9, 2023

Please test with following PRs:
swiftlang/swift-installer-scripts#256

@swift-ci please build toolchain Windows platform

@tristanlabelle
Copy link
Contributor Author

This failed because the list of redist files varies per toolchain version. The fix will be to harvest the directory. Working on this

Build FAILED.

       "C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\bundle\installer.wixproj" (default target) (1:7) ->
       "C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\rtl\msi\rtlmsi.wixproj" (default target) (4:5) ->
       (CoreCompile target) -> 
         C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\rtl\msi\rtlmsi.wxs(49): error WIX0103: Cannot find the File file 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\VC\\Redist\\MSVC\\14.34.31931\\x64\\Microsoft.VC143.CRT\\vcruntime140_threads.dll'. The following paths were checked: C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\VC\\Redist\\MSVC\\14.34.31931\\x64\\Microsoft.VC143.CRT\\vcruntime140_threads.dll [C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\rtl\msi\rtlmsi.wixproj]

@compnerd
Copy link
Member

Please test with following PRs:
swiftlang/swift-installer-scripts#256

@swift-ci please build toolchain Windows platform

1 similar comment
@compnerd
Copy link
Member

Please test with following PRs:
swiftlang/swift-installer-scripts#256

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants