Skip to content

Add support for SWIFTCI_USE_LOCAL_DEPS in swift-inspect #69744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

stevapple
Copy link
Contributor

If the SWIFTCI_USE_LOCAL_DEPS environment variable is set, we're building in the Swift.org CI system alongside other projects in the Swift toolchain and we can depend on local versions of our dependencies instead of fetching them remotely.

Also removes manual CXX flags set by build.ps1 invocation since they're already in Package.swift.

If the `SWIFTCI_USE_LOCAL_DEPS` environment variable is set, we're building in the Swift.org CI system alongside other projects in the Swift toolchain and we can depend on local versions of our dependencies instead of fetching them remotely.
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is applied almost universally in all the packages, I don't see the harm in supporting it.

@compnerd
Copy link
Member

compnerd commented Nov 9, 2023

@swift-ci please test

@compnerd
Copy link
Member

compnerd commented Nov 9, 2023

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member

@swift-ci please test Windows platform

@compnerd compnerd merged commit d2e2214 into swiftlang:main Nov 10, 2023
@stevapple stevapple deleted the inspect-local-deps branch November 10, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants