[TBDGen] Capture segment symbols are defined in & emit tbd-v5 format #69779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I expect some tests that invoke the Xcode toolchain linker to fail as Xcode14 is too old to read tbdv5. They should be resolved by: #69485 I can temporarily disable them, but I figure its better to get feedback first. |
xymus
reviewed
Nov 13, 2023
| // RUN: %target-swift-frontend -typecheck %s -emit-tbd-path - -tbd-current-version 20.10 | %FileCheck %s --check-prefix TWENTYPOINTTEN | ||
| // RUN: %target-swift-frontend -typecheck %s -tbd-install_name some_dylib -emit-tbd-path - -tbd-current-version 2.0 | %FileCheck %s --check-prefix TWOPOINTZERO | ||
| // RUN: %target-swift-frontend -typecheck %s -tbd-install_name some_dylib -emit-tbd-path - -tbd-current-version 2 | %FileCheck %s --check-prefix TWOPOINTZERO | ||
| // RUN: %target-swift-frontend -typecheck %s -tbd-install_name some_dylib -emit-tbd-path - -tbd-current-version 20.10 | %FileCheck %s --check-prefix TWENTYPOINTTEN |
There was a problem hiding this comment.
I notice you're adding many -tbd-install_name to tests, is it a requirement to set it explicitly now?
There was a problem hiding this comment.
Yes! It is an assert check in LLVM now. https://github.com/llvm/llvm-project/blob/main/llvm/lib/TextAPI/TextStubV5.cpp#L370
|
@swift-ci please test |
tshortli
approved these changes
Nov 13, 2023
|
@swift-ci please test |
* Fixup tests to handle new json based output. * Use llvm-nm & readtapi to verify tbd file outputs. resolves: rdar://117604275
cyndyishida
force-pushed
the
Swift-tbdv5
branch
from
d016c5f to
3ccaaf5
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD-v5 is the new json format for TBD files. One can view the format spec by running
man tapi-tbdon any >=Xcode15 install. Because it captures the segment the symbols are defined in, to restore back information lost compared to binary dylibs, it is also now recorded for TBDGen in the compiler. This is a best effort, as there is no way to definitively know where the symbol ends up until after the linker has assembled the binary.This patch also updates tests to
Resolves: rdar://117604275