Remove the source.request.syntacticrename request
#69784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`source.request.find-syntactic-rename-ranges` should be used instead.
…output inline with the test file
ahoppen
requested review from
bnbarham,
rintaro and
hamishknight
as code owners
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Nov 10, 2023
| virtual void findRenameRanges(llvm::MemoryBuffer *InputBuf, | ||
| ArrayRef<RenameLocations> RenameLocations, | ||
| ArrayRef<const char *> Args, | ||
| CategorizedRenameRangesReceiver Receiver) = 0; | ||
| virtual void | ||
| virtual void |
There was a problem hiding this comment.
Accidental? Does clang-format not remove this?
There was a problem hiding this comment.
It does. I just didn’t push after running git-clang-format 🙈
hamishknight
approved these changes
Nov 13, 2023
ahoppen
force-pushed
the
ahoppen/remove-syntacticrename
branch
from
2f6d676 to
d0f9346
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
source.request.syntacticrenameisn’t used anywhere andsource.request.find-syntactic-rename-rangesshould be used instead.