Revert "[Performance] iterate the smaller set during Set.intersect()" #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribozavr
added a commit
that referenced
this pull request
Dec 21, 2015
Revert "[Performance] iterate the smaller set during Set.intersect()"
|
Just a thought: if the regression were found on Set but not Dictionary, then it's more likely caused by this one than #616, which affects both. |
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
…llvm-project Update the llvm-project branch for main config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #576
We have detected performance regressions in Set between December 18 and now. We are not sure which commit caused them, so I'm reverting this change, and will apply them one by one, measuring the performance.