Skip to content

Revert "Add a mark_dependence while emitting SIL for uninitialized array allocation " #69807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2023
Merged

Revert "Add a mark_dependence while emitting SIL for uninitialized array allocation " #69807

merged 1 commit into from
Nov 12, 2023

Conversation

shahmishal
Copy link
Member

@shahmishal shahmishal commented Nov 12, 2023 •
edited
Loading

Reverts #69450

After bisecting the changes on swift repo, I believe this PR introduced error.

error: 'swift-crypto': close error: Unknown error -1
error: 'swift-format': close error: Unknown error -1

Commits tested by building toolchain preset on swift repository:
✅ 05271d3
✅ 4ec627e
✅ 2b594b2
✅ 8f466f7
✅ eee45f7
❌ 192bb2e

Hopefully, this will unblock https://ci.swift.org/job/oss-swift-package-macos/ bot.

@shahmishal
Copy link
Member Author

@swift-ci build toolchain macOS

@shahmishal
Copy link
Member Author

@swift-ci smoke test

@shahmishal shahmishal mentioned this pull request Nov 12, 2023
Open
@shahmishal shahmishal merged commit cabb5e1 into main Nov 12, 2023
@shahmishal shahmishal deleted the revert-69450-uninarrayfix branch November 12, 2023 21:38
meg-gupta added a commit to meg-gupta/swift that referenced this pull request Dec 5, 2023
@meg-gupta
Revert "Merge pull request swiftlang#69807 from apple/revert-69450-un…
054dcac 
…inarrayfix"

This reverts commit cabb5e1, reversing
changes made to 09688ab.
meg-gupta added a commit to meg-gupta/swift that referenced this pull request Dec 6, 2023
@meg-gupta
Revert "Merge pull request swiftlang#69807 from apple/revert-69450-un…
86b6513 
…inarrayfix"

This reverts commit cabb5e1, reversing
changes made to 09688ab.
Catfish-Man pushed a commit to Catfish-Man/swift that referenced this pull request Jan 19, 2024
@meg-gupta @Catfish-Man
Revert "Merge pull request swiftlang#69807 from apple/revert-69450-un…
6606211 
…inarrayfix"

This reverts commit cabb5e1, reversing
changes made to 09688ab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shahmishal