Skip to content

[embedded] Avoid using swiftcc on targets that don't support it #69822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kubamracek
Copy link
Contributor

Building for targets other than x86-64, ARM and AArch64 causes problems when using swiftcc and __attribute__((swiftcall)) (failed compilations, compiler crashes). Let's for now simply fall back to the C calling convention on targets that don't support swiftcc.

@kubamracek kubamracek requested a review from a team as a code owner November 13, 2023 21:01
@kubamracek
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kubamracek kubamracek merged commit 7d7cf1f into swiftlang:main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants