Skip to content

Yet more typed throws fixes #69824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 14, 2023
Merged

Yet more typed throws fixes #69824

merged 4 commits into from
Nov 14, 2023

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Nov 13, 2023 •
edited
Loading

Minor fixes for typed throws that were uncovered while testing the typed throws map implementation in the standard library:

  • When substituting into a generic throws(E), and E is either any Error or Never, simplify to throws or non-throwing
  • Teach TransferNonSendable, forEach unrolling, and speculative devirtualization that not all Error BB's have arguments

@DougGregor
Drop throws(any Error) and throws(Never) sugar after substitution
eb3d7c5 
When substitution into a function type with `throws(E)` produces either
`throws(any Error)` or `throws(Never)`, adjust the resulting function
type to the equivalent `throws` or non-throwing.
@DougGregor
Teach TransferNonSendable that not all Error BB's have arguments
27b6a64
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor DougGregor enabled auto-merge November 13, 2023 22:25
@DougGregor DougGregor mentioned this pull request Nov 13, 2023
Merged
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor
Copy link
Member Author

@swift-ci please smoke test Windows

@DougGregor DougGregor merged commit 273937a into swiftlang:main Nov 14, 2023
@DougGregor DougGregor deleted the typed-throws-fixes branch November 14, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DougGregor