Sema: Associated type inference skips witnesses that might trigger a request cycle #69826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
assoc-type-inference-cycle
branch
2 times, most recently
from
be87c2c to
3b78215
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
…request cycle This implements a structural walk over the TypeRepr to catch situations where we attempt to infer `A` from `func f(_: A)`, which references the concrete `A` that will be synthesized in the conforming type. Fixes: - rdar://34956654 / swiftlang#48680 - rdar://38913692 / swiftlang#49066 - rdar://56672411 - swiftlang#50010 - rdar://81587765 / swiftlang#57355 - rdar://117442510
slavapestov
force-pushed
the
assoc-type-inference-cycle
branch
from
3b78215 to
96432e6
Compare
|
@swift-ci Please smoke test |
This was referenced Nov 14, 2023
This was
linked to
issues
Nov 17, 2023
This was referenced Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a structural walk over the TypeRepr to catch situations where we attempt to infer
Afromfunc f(_: A), which references the concreteAthat will be synthesized in the conforming type.Fixes: