[NCGenerics] more work towards getting the stdlib building #69842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a batch of otherwise hard-to-write-a-regression test fixes for situations that came up while testing with the stdlib.
It's not technically correct to ask the generic signature without first
reducing the type, i.e., we really have to do this:
```
auto ty = sig->getReducedType(this)
// fast path
if (ty.isTypeParamter())
return sig->requiresProtocol(s, copyable)
// slow path
mapTypeIntoContext(...)
```
Since reducing the type is basically what `mapTypeIntoContext` is also
going to do, it's not really worth doing this or having the fast-path at
all. This need to reduce the type originally came while building the
stdlib. We ran into a problem with this:
```
extension Slice {
public func initialize<S>(
from source: S
) -> (unwritten: S.Iterator, index: Index)
where S: Sequence, Base == UnsafeMutableBufferPointer<S.Element>
}
```
where we have `struct Slice<Base: Collection>` and
```
extension Slice: Collection {
typealias Index = Base.Index
// ...
}
```
|
@swift-ci smoke test |
kavon
force-pushed
the
ncgenerics-stdlib-building
branch
from
6aea5b2 to
03ad1c6
Compare
|
@swift-ci smoke test |
I was not expanding default requirements in AbstractGenericSignatureRequest or ExistentialLayout. Also fixes printing of composition types.
kavon
force-pushed
the
ncgenerics-stdlib-building
branch
from
03ad1c6 to
2cd2989
Compare
kavon
changed the title
kavon
requested review from
hborla,
slavapestov,
xedin and
tshortli
as code owners
|
@swift-ci please test |
After review, Slava and I decided it's not a good idea to provide a `TypeBase::getAnyTypeDecl` method, as it is not typically what people generally should use, as it doesn't handle all cases (type parameters with no associated decl, for example).
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to shake out issues with just building the existing stdlib with NoncopyableGenerics enabled. This PR does not enable that by-default, so you'll still have to add
swift-stdlib-experimental-noncopyable-generics=1to your build-script preset.fixes rdar://118697289