MoveOnlyChecker: Properly insert cleanup for dead try_apply def. #69887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a address-only noncopyable value is dead-def'ed by an indirect return from a `try_apply`, the cleanup should be inserted on the normal return successor block. Fixes rdar://118255228.
|
@swift-ci Please test |
|
@swift-ci please build macOS toolchain |
gottesmm
reviewed
Nov 16, 2023
|
|
||
| func main() { | ||
| print("starting") | ||
| _ = try? test1a() |
There was a problem hiding this comment.
@jckarter can you add in a main only PR, a test case that validates the SILGen we emit here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a address-only noncopyable value is dead-def'ed by an indirect return from a
try_apply, the cleanup should be inserted on the normal return successor block. Fixes rdar://118255228.