Skip to content

[swift-inspect] Fix integer type mismatch on watchOS build. #69896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Nov 15, 2023

Convert integers to to swift_reflection_ptr_t instead of UInt64 since watchOS uses UInt as its pointer type.

rdar://118458631

Convert integers to to `swift_reflection_ptr_t` instead of `UInt64` since watchOS uses `UInt` as its pointer type.

rdar://118458631
@mikeash
Copy link
Contributor Author

mikeash commented Nov 15, 2023

@swift-ci please smoke test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems strictly better to me.

@mikeash
Copy link
Contributor Author

mikeash commented Nov 15, 2023

It doesn't build on watchOS otherwise (because we messed up the pointer type there and now we're stuck with it), so, yeah. 😄

@mikeash mikeash enabled auto-merge November 15, 2023 20:36
@mikeash mikeash merged commit 9af39f9 into swiftlang:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants