utils: integrate support for caching when building #69961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @shahmishal @etcwilde |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test |
Integrate support for sccache into the build system. This allows us to get a reasonable performance increase for clean builds for the C/C++ side of the build. This is currently limited to the MSVC compiler as the extended compiler flags cause issues for sccache.
|
@swift-ci please test |
etcwilde
reviewed
Dec 4, 2023
| @@ -26,9 +26,6 @@ The path to a directory that mimics a file system image root, | |||
| under which "Library" and "Program Files" subdirectories will be created | |||
| with the files installed by CMake. | |||
|
|
|||
| .PARAMETER BuildType | |||
There was a problem hiding this comment.
Is the removal of debug builds related here? sccache should see the flag in the compiler invocation and realize that it's a different object being emitted.
There was a problem hiding this comment.
Yes, it is related. The Swift build system is just not able to support this (sccache + PDBs don't work very well together, the other changes to use the embedded debug is related). Once we upgrade to a reasonable version of CMake, we should be able to use the CMAKE_MSVC_DEBUG_INFORMATION_FORMAT=Embedded and get the build types to work again.
etcwilde
approved these changes
Dec 4, 2023
|
@swift-ci please build toolchain Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate support for sccache into the build system. This allows us to get a reasonable performance increase for clean builds for the C/C++ side of the build. This is currently limited to the MSVC compiler as the extended compiler flags cause issues for sccache.