Skip to content

build.ps1: Build installer wixproj as bundle #69969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2023
Merged

build.ps1: Build installer wixproj as bundle #69969

merged 1 commit into from
Nov 27, 2023

Conversation

tristanlabelle
Copy link
Contributor

@tristanlabelle tristanlabelle commented Nov 17, 2023

We were removing the semantic version suffixes for the whole bundle because we used the logic for individual MSI's, which don't support semantic versioning suffixes. This is now handled in installer.wixproj as per the dependent swiftlang/swift-installer-scripts#252

@compnerd
Copy link
Member

Please test with following PRs:
swiftlang/swift-installer-scripts#252

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member

@swift-ci please test

@compnerd compnerd merged commit 10aa58f into swiftlang:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants