GenericSpecializer: support specializing typed throws #70000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci test |
|
@swift-ci benchmark |
… results Indirect error results must not be included in the final apply arguments which they are not present in the callee.
It's not used
This means to support specializing functions with indirect error results. Also, when specializing (and the concrete error type is loadable), convert the indirect error to a direct error. rdar://118532113
eeckstein
force-pushed
the
specialize-typed-throws
branch
from
79de0a7 to
8458481
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means to support specializing functions with indirect error results.
Also, when specializing (and the concrete error type is loadable), convert the indirect error to a direct error.
rdar://118532113
Also, fix try_apply -> apply transformation for indirect error results in SimplifyCFG