[CodeCompletion] Add keyword completion for 'some', 'any', 'repeat', and 'each' #70014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
ahoppen
requested review from
bnbarham,
rintaro,
hamishknight,
CodaFi and
DougGregor
as code owners
ahoppen
force-pushed
the
ahoppen/some-any-completion
branch
from
f1a5e89 to
7637263
Compare
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Nov 30, 2023
…and 'each' The implementation is not 100% perfect but I don’t think it’s worth putting too much effort into it passing more information down in the parser if 'repeat' and 'each' are valid if we are going to remove the current parser anyway. rdar://95725895
ahoppen
force-pushed
the
ahoppen/some-any-completion
branch
from
7637263 to
9cb2a24
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is not 100% perfect (it suggests
repeatandeachin places where they aren’t semantically valid) but I don’t think it’s worth putting too much effort into it passing more information down in the parser if 'repeat' and 'each' are valid if we are going to remove the current parser anyway.rdar://95725895