Add test case for #70019

[WindowsMEMZ]

Added a test case for #70019.

[WindowsMEMZ]

@swift-ci Please smoke test

[xedin]

I am away from my computer whole day today and tomorrow but I will take a look on Monday.

[WindowsMEMZ]

I away from my computer whole day today and tomorrow but I will take a look on Monday.

OK, Thanks. By the way, can I review other pull requests like you? I didn't find the way. And I wonder can I see a bug's detail by rdar://, or it just for internal?

[xedin]

Okay here is what is passing locally for me:

// RUN: %target-typecheck-verify-swift -swift-version 5
// RUN: %target-typecheck-verify-swift -swift-version 5 -enable-library-evolution -I %t

// REQUIRES: concurrency

// https://github.com/apple/swift/issues/70019

@usableFromInline
struct Foo { // expected-note {{consider making struct 'Foo' conform to the 'Sendable' protocol}}
  var integer: Int
}

struct Bar: Sendable {
  // FIXME: This warning should only be thrown when it complies with library evolution mode
  // FIXME: If @usableFromInline is removed from Foo the Sendable conformance is synthesized as expected.
  var foo: Foo // expected-warning {{stored property 'foo' of 'Sendable'-conforming struct 'Bar' has non-sendable type 'Foo'}}
}

Notice that it has two // RUN: commands because your FIXME states that this warning should only be thrown in library evolution mode we need two runs to make sure that the test starts failing as soon as the issue is fixed.

Also I suggested naming it issueNNN.swift but the format is actually issue-NNNN.swift, sorry about that!

[xedin]

By the way, can I review other pull requests like you?

Sure, feel free to ping me about other PRs.

[WindowsMEMZ]

@xedin Thank you, it really helps! Please start a Swift CI test to make it ready to merge.

[AnthonyLatsis]

By the way, can I review other pull requests like you? I didn't find the way.

Anyone can review pull requests in this repository. Finding an article on how to review changes in pull requests should be straightforward.

And I wonder can I see a bug's detail by rdar://, or it just for internal?

That is an identifier in the internal bug tracker, yes.

[AnthonyLatsis]

Please squash your commits and see to a proper commit message before we go for merge. You might also want to read our How to Submit Your First Pull Request guidelines.

[WindowsMEMZ]

Please squash your commits and see to a proper commit message before we go for merge. You might also want to read our How to Submit Your First Pull Request guidelines.

Thanks, I'll read it.

[xedin]

LGTM, thank you! Once -I %t is dropped we can land this.

[AnthonyLatsis]

Thanks! Could you use the PR title as the commit message instead? Git wants them in the imperative mood, plus, GitHub conveniently turns hash references, such as #70019, into links.

[WindowsMEMZ]

@AnthonyLatsis @xedin All done! Please run the checks and merge it.

[AnthonyLatsis]

We were talking just about the -I %t argument, not the command itself.

[WindowsMEMZ]

We were talking just about the -I %t argument, not the command itself.

I'm sorry about that, it's OK now.

[AnthonyLatsis]

@swift-ci please smoke test

[xedin]

@swift-ci please test macOS platform

[xedin]

let's run a full test on macOS just in case