[ConstraintSystem] Implement sendability inference for key path expressions #70076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all currently checked types
Since the type of the instruction could be existential it's better to keep retrival logic in one place.
…d to a key path type This is currently limited to `InferSendableFromCaptures` feature but a valid thing to do in general because otherwise it won't be possible to determine the sendability of the key path type.
…ial type A way to mark key path as Sendable is to extend its type with `& Sendable`. This is something that makes the type of a key path expression an existential with superclass bound expressed as a known key path type.
…lity of key path expressions When `InferSendableFromCaptures` feature is enabled `inferKeyPathLiteralCapability` should examine subscript arguments to determine whether the key path type is sendable or not, and if so, inform inference to produce `& Sendable` existential type as a binding. Binding key path type is delayed until all subscript arguments are fully resolved.
…when `InferSendableFromCaptures` is enabled
xedin
added
the
swift evolution pending discussion
xedin
requested review from
ktoso,
kavon,
hborla,
slavapestov,
ahoppen,
bnbarham,
rintaro and
hamishknight
as code owners
… exprs is inferred correctly
xedin
force-pushed
the
sendable-keypath-literals
branch
from
b3c70ef to
3d6ddd5
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test Linux platform |
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gated by
InferSendableFromCapturesexperimental flag.Swift forums pitch - https://forums.swift.org/t/pitch-inferring-sendable-for-methods-and-key-path-literals/68011
Sendability of key path expressions is expressed by means of protocol composition
between key path type and
Sendableprotocol i.e.KeyPath<String, Int> & Sendable.Augment the key path capability inference to include sendability checking based
on whether subscript component arguments captured by a key path are sendable
or not or, if there are subscript components a key path expression is always sendable.
Resolves: rdar://75861003