[DebugInfo][SILGen] Ensure "guard let" is lowered with a non-implicit location #70111
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
felipepiovezan
commented
Nov 30, 2023
| } | ||
|
|
||
| let a = A() | ||
| a.foo() |
There was a problem hiding this comment.
@adrian-prantl if you have a suggestion for a better test, please let me know
… location Prior to this patch, a "guard let" was being lowered with an implicit debug location, causing it to be dropped in later stages of the compiler, and making it impossible to set a breakpoint in that line. This was tracked down to a piece of code in `SILGenFunction::emitExprInto`, which takes an optional Location parameter that was being ignored in one code path.
|
I had changed the test to make sure I saw it failing and forgot to undo the change prior to committing.. |
|
Other than that, the tests are clean. I also ran the LLDB tests locally |
|
@swift-ci please test |
felipepiovezan
force-pushed
the
felipe/fix_incorrect_debug_loc
branch
from
5a63524 to
8baf933
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, a "guard let" was being lowered with an implicit debug location, causing it to be dropped in later stages of the compiler, and making it impossible to set a breakpoint in that line.
This was tracked down to a piece of code in
SILGenFunction::emitExprInto, which takes an optional Location parameter that was being ignored in one code path.