[5.10] [Profiler] Remove an assertion #70120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the recent change to how we simplify counters (rdar://118185163), we can now end up hitting this assertion for certain do-catch statements. The counter has always been wrong here, and previously would have underflowed at runtime (rdar://100470244). This issue has been properly fixed on main, but we haven't cherry-picked that fix to 5.10 since it requires a bunch of other changes. For now, just remove the assertion to maintain the previous behavior. rdar://118896974
hamishknight
added
🍒 release cherry pick
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
bnbarham
approved these changes
Nov 30, 2023
|
Source compat failure is a UPASS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #70072