[ASTGen] Generate compound name expression #70138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bridge DeclBaseName, DeclNameRef, and DeclNameLoc. Implement UnresolvedMemberExpr generation.
rintaro
requested review from
zoecarver,
CodaFi,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please smoke test |
rintaro
commented
Nov 30, 2023
| _ = self.method(arg:_:) | ||
| } | ||
|
|
||
| // FIXME: Compute 'static' location |
There was a problem hiding this comment.
hamishknight
approved these changes
Dec 1, 2023
ahoppen
reviewed
Dec 1, 2023
Comment on lines
+89
to
+96
| SWIFT_NAME("BridgedDeclBaseName.createConstructor()") | ||
| BridgedDeclBaseName BridgedDeclBaseName_createConstructor(); | ||
|
|
||
| SWIFT_NAME("BridgedDeclBaseName.createDestructor()") | ||
| BridgedDeclBaseName BridgedDeclBaseName_createDestructor(); | ||
|
|
||
| SWIFT_NAME("BridgedDeclBaseName.createSubscript()") | ||
| BridgedDeclBaseName BridgedDeclBaseName_createSubscript(); |
There was a problem hiding this comment.
Can’t these be static functions of BridgedDeclBaseName. IIRC I used static members in NameMatcherBridging and it worked.
Similar for the other create functions here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bridge DeclBaseName, DeclNameRef, and DeclNameLoc.
Implement UnresolvedMemberExpr generation.