[Serialized diagnostics] Avoid generating filenames that break the reader #70139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader The serialized diagnostics reader has one very specific limitation it places on filenames: they must not end in `/`, because that makes them look like a directory. This is not documented, and the diagnostics reader will unceremoniously crash when trying to read such a file. While the reader should be fixed to at least fail gracefully in such cases, Swift also shouldn't generate such filenames. Right now, they can be generated when referencing an entity named `/` that is synthesized or comes from a module. When we encounter such file names, append `_operator` to avoid the problem. Fixes rdar://118217560.
|
@swift-ci please smoke test |
bnbarham
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serialized diagnostics reader has one very specific limitation it places on filenames: they must not end in
/, because that makes them look like a directory. This is not documented, and the diagnostics reader will unceremoniously crash when trying to read such a file.While the reader should be fixed to at least fail gracefully in such cases, Swift also shouldn't generate such filenames. Right now, they can be generated when referencing an entity named
/that is synthesized or comes from a module. When we encounter such file names, append_operatorto avoid the problem.Fixes rdar://118217560.