[CMake] In LLVM unified builds, depend on the generation of Clang headers #70144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ders If one is building a LLVM unified build, with Swift as an external project, SwiftCompilerSources can compile before the `.td` files that generate Clang headers are finished, which will make the compilation fail to find some files (the `.inc` files derived from those `.td`). Make the library that uses the header depend on `clang-tablegen-targets` to ensure those are done before the library is tried to be used. This is not a problem in the normal `build-script` builds because in those cases, the LLVM/Clang headers are build way before Swift is started to be build.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one is building a LLVM unified build, with Swift as an external project, SwiftCompilerSources can compile before the
.tdfiles that generate Clang headers are finished, which will make the compilation fail to find some files (the.incfiles derived from those.td). Make the library that uses the header depend onclang-tablegen-targetsto ensure those are done before the library is tried to be used.This is not a problem in the normal
build-scriptbuilds because in those cases, the LLVM/Clang headers are build way before Swift is started to be build.